Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gf-recalculate-on-image-wrapper-click.js: Added snippet to ensure calculations as soon as we click the image wrapper. #999

Merged

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2816466531/76565

Summary

Gravity Forms image wrapper 'click' isn't trigerring calculations. Tested till Gravity Forms 2.9.1.3.

A quick snippet to address the issue and ensure calculations work!

https://www.loom.com/share/67558ad245c24fff9ea11802b5352a9e

…alculations as soon as we click the image wrapper.
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of housekeeping items I've suggested.

S&M with:

`gf-recalculate-of-image-wrapper-click.js`: Added snippet to trigger calculations when Image Choice images are clicked.

experimental/gf-recalculate-of-image-wrapper-click.js Outdated Show resolved Hide resolved
experimental/gf-recalculate-of-image-wrapper-click.js Outdated Show resolved Hide resolved
…alculations as soon as we click the image wrapper.
Copy link

github-actions bot commented Jan 14, 2025

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 768c65f

…alculations as soon as we click the image wrapper.
@saifsultanc saifsultanc changed the title gf-recalculate-of-image-wrapper-click.js: Added snippet to ensure calculations as soon as we click the image wrapper. gf-recalculate-on-image-wrapper-click.js: Added snippet to ensure calculations as soon as we click the image wrapper. Jan 14, 2025
@saifsultanc saifsultanc merged commit a6145f9 into master Jan 14, 2025
3 of 4 checks passed
@saifsultanc saifsultanc deleted the saif/add/76565-add-image-wraper-recalculate-snippet branch January 14, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants