Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: add docker lint #18

Merged
merged 20 commits into from
Sep 26, 2023
Merged

Draft: add docker lint #18

merged 20 commits into from
Sep 26, 2023

Conversation

rreinoldsc
Copy link
Contributor

@rreinoldsc rreinoldsc commented Sep 25, 2023

Added docker lint, and addressed the following:

-:1 DL3029 warning: Do not use --platform flag with FROM
-:9 DL3013 warning: Pin versions in pip. Instead of `pip install <package>` use `pip install <package>==<version>` or `pip install --requirement <requirements file>`
-:9 DL3042 warning: Avoid use of cache directory with pip. Use `pip install --no-cache-dir <package>`

@rreinoldsc rreinoldsc marked this pull request as draft September 25, 2023 16:42
@rreinoldsc rreinoldsc changed the title add docker lint command Draft: add docker lint Sep 25, 2023
@rreinoldsc rreinoldsc marked this pull request as ready for review September 25, 2023 21:09
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
@gx-cla-bot
Copy link

gx-cla-bot bot commented Sep 26, 2023

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: pre-commit-ci[bot]

@rreinoldsc rreinoldsc merged commit 02200da into main Sep 26, 2023
9 checks passed
@rreinoldsc rreinoldsc deleted the f/add_docker_lint branch September 26, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants