-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade poetry.lock
after updating Docker image to Python 3.10.13
#208
Upgrade poetry.lock
after updating Docker image to Python 3.10.13
#208
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 81.77% 81.77%
=======================================
Files 26 26
Lines 944 944
=======================================
Hits 772 772
Misses 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pyproject.toml
Outdated
@@ -1,6 +1,6 @@ | |||
[tool.poetry] | |||
name = "great_expectations_cloud" | |||
version = "20240417.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update makes a lot of dependency changes.
- I would suggest waiting until [Maintenance] add dev docker tag to latest releases and pre-releases #207 merges, making this a pre-release, and doing some manual testing before merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok great idea @Kilo59. I'll follow up here tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile
Outdated
RUN apt-get install --no-install-recommends libpq-dev python-dev build-essential libsnappy-dev | ||
|
||
RUN pip --no-cache-dir install poetry==1.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN apt-get install --no-install-recommends libpq-dev python-dev build-essential libsnappy-dev | |
RUN pip --no-cache-dir install poetry==1.6.1 | |
RUN pip --no-cache-dir install poetry==1.8.2 |
Not sure why I didn't notice this earlier, but this is an old version of poetry.
Try reverting the extra apt-get
commands and seeing if this by itself fixes it.
3.10.13
after confirming Docker image build
…ion-followup * fix-310_13_container: Apply suggestions from code review pin python3-dev cleanup cleanup fix poetry install add back gcc pin combine no pseudo terminal only minimal deps test docker build in ci working
3.10.13
after confirming Docker image buildpoetry.lock
after updating Docker image to Python 3.10.13
poetry.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command was run in a python 3.10.13 environment, which matches Docker.
Just to note, whether or not the lock command was run in a python 3.10.13 environment is largely irrelevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Kilo59. This really helps clear up my understanding :)
What does this PR do?
3.10.13
#205 tried tod.Reference
containerize-agent
stage of CI/CD : here#11 47.69 Note: This error originates from the build backend, and is likely not a problem with poetry but with psutil (5.9.8) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "psutil (==5.9.8)"'.
poetry update
to update thepoetry.lock
file.3.10.13
environment, which matches Docker.