Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove build tools from Docker layer #283

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

rreinoldsc
Copy link
Contributor

@rreinoldsc rreinoldsc commented May 29, 2024

Remove build tools from final image, which addresses container vuln for python 3.11

Tests performed:

  • build tools fail using base image python version
  • psutil cannot be removed from dep chain
  • upgrade python3-dev, failed

Conclusions:

  • python3-dev: max version supported by our base image is 3.11.2
  • psutil required indirectly by GX core

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.20%. Comparing base (6efe819) to head (44c3590).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files          25       25           
  Lines         928      928           
=======================================
  Hits          800      800           
  Misses        128      128           
Flag Coverage Δ
3.10 74.67% <ø> (ø)
3.11 74.67% <ø> (ø)
3.8 74.54% <ø> (ø)
3.9 74.54% <ø> (ø)
integration 67.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rreinoldsc rreinoldsc requested review from Kilo59 and wookasz May 29, 2024 17:38
@rreinoldsc rreinoldsc merged commit b6001cd into main May 29, 2024
19 checks passed
@rreinoldsc rreinoldsc deleted the m/address_3_11_vuln_alert branch May 29, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants