Remove all but standardized version of python in build #370
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
=======================================
Coverage ? 87.76%
=======================================
Files ? 26
Lines ? 1022
Branches ? 0
=======================================
Hits ? 897
Misses ? 125
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -42,7 +42,7 @@ jobs: | |||
| tests: | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | |||
| python-version: ["3.10.14"] | |||
There was a problem hiding this comment.
This has come up before and I think it was decided to keep testing all versions.
However python 3.8 is going to EOL in 3 months so I think it's a relatively easy call to drop support for that.
https://endoflife.date/python
Even if product said we can drop support for everything but 3.10 I would still suggest we keep testing (at least unit-tests) on 3.11 and higher to keep our upgrade path clear.
Having said all that.
It would also be trivial to deal with the github API rate limit by making that test only run on one of the python versions.
| python-version: ["3.10.14"] | |
| python-version: ["3.9", "3.10.14", "3.11"] |
There was a problem hiding this comment.
@Kilo59 can you point me to where this was decided?
There was a problem hiding this comment.
I don't understand why we would add unnecessary complexity for ourselves if we don't support running this outside of docker
There was a problem hiding this comment.
@wookasz is it possible to know the version that people are running when downloading the agent from pypi?
There was a problem hiding this comment.
@Shinnnyshinshin @wookasz
https://pypistats.org/packages/great-expectations-cloud
Yesterday (8-12-24), there were 6 3.8 downloads.
|
closing stale PR |
Remove usage of python 3.8 in CI steps and all 3.8, 3.9, and 3.11 testing
Why
We're only using 3.10.14 in our
dockerimage and we're hitting up against GitHub rate limits