Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded build-time packages gcc and cpp #411

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

wookasz
Copy link
Collaborator

@wookasz wookasz commented Aug 28, 2024

Removes the gcc-12, cpp-12, and cpp from the image after build steps complete. These are unneeded and gcc-12 is getting flagged by vulnerability scans.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (1df0d69) to head (5bcf817).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files          26       26           
  Lines        1030     1030           
=======================================
  Hits          907      907           
  Misses        123      123           
Flag Coverage Δ
3.10 74.75% <ø> (ø)
3.11 74.75% <ø> (ø)
3.8 74.61% <ø> (ø)
3.9 74.61% <ø> (ø)
integration 70.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Kilo59 Kilo59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my earlier comment. I can't read a diff 😆

@wookasz wookasz merged commit d155fb1 into main Aug 28, 2024
19 checks passed
@wookasz wookasz deleted the m/remove-gcc-cpp branch August 28, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants