Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable analytics in OSS code #558

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Disable analytics in OSS code #558

merged 2 commits into from
Nov 25, 2024

Conversation

TrangPham
Copy link
Contributor

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (79967d7) to head (92d0864).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   84.62%   84.62%           
=======================================
  Files          25       25           
  Lines        1171     1171           
=======================================
  Hits          991      991           
  Misses        180      180           
Flag Coverage Δ
3.10 71.47% <ø> (ø)
3.11 71.47% <ø> (ø)
3.9 71.34% <ø> (ø)
integration 69.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dockerfile Outdated
@@ -46,4 +46,7 @@ RUN apt-get remove -y \
cpp-12 \
cpp

# Disable analytics in OSS
RUN export GX_ANALYTICS_ENABLED=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not use the ENV instruction? https://docs.docker.com/reference/dockerfile/#env

Copy link
Collaborator

@billdirks billdirks Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, you should use ENV. Look at this example: https://stackoverflow.com/questions/33379393/docker-env-vs-run-export

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know that existed. Updating

Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, but if this works no need to block.

Copy link
Collaborator

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Dockerfile Outdated Show resolved Hide resolved
@TrangPham TrangPham enabled auto-merge (squash) November 25, 2024 18:22
@TrangPham TrangPham merged commit 9c5165e into main Nov 25, 2024
16 checks passed
@TrangPham TrangPham deleted the disable-analytics branch November 25, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants