[BUGFIX] Ensure that file-backed domain objects are stored in JSON files #10523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cdkini
changed the title
cdkini
commented
Oct 15, 2024
Comment on lines
84
to
86
| if issubclass(store_backend_class, TupleStoreBackend): | ||
| # Provide defaults for this common case | ||
| store_backend["filepath_suffix"] = store_backend.get("filepath_suffix", ".json") |
There was a problem hiding this comment.
Duplicate logic now that default is set
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10523 +/- ##
========================================
Coverage 80.20% 80.21%
========================================
Files 461 461
Lines 39988 40004 +16
========================================
+ Hits 32074 32090 +16
Misses 7914 7914
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
billdirks
reviewed
Oct 15, 2024
| @@ -53,8 +53,9 @@ def __init__( # noqa: PLR0913 | |||
| self.forbidden_substrings = forbidden_substrings | |||
| self.platform_specific_separator = platform_specific_separator | |||
|
|
|||
| if filepath_template is not None and filepath_suffix is not None: | |||
| raise ValueError("filepath_suffix may only be used when filepath_template is None") # noqa: TRY003 | |||
| if filepath_template and filepath_suffix: | |||
There was a problem hiding this comment.
I'd log an info message here saying both were specified so we are taking template.
billdirks
approved these changes
Oct 15, 2024
…_expectations into b/_/ensure_domain_objects_store_with_json_suffix
…_expectations into b/_/ensure_domain_objects_store_with_json_suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!