Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce PEP-585 #10594

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Enforce PEP-585 #10594

wants to merge 5 commits into from

Conversation

tyler-hoffman
Copy link
Contributor

@tyler-hoffman tyler-hoffman commented Oct 30, 2024

Reference. PEP-585

Changes

  • Removes UP006 from the ignore list in pyproject.toml
  • Ran invoke lint --fix --unsafe-fixes
  • Manually updated other things that lint complained about (mostly catching exceptions and immediately reraising, which violated another rule
  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit d329f21
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/672389d840e8e70008955942
😎 Deploy Preview https://deploy-preview-10594.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 88.61607% with 102 lines in your changes missing coverage. Please review.

Project coverage is 67.94%. Comparing base (58e2823) to head (d329f21).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...d_profiler/domain_builder/column_domain_builder.py 23.80% 16 Missing ⚠️
...etric_provider/map_condition_auxilliary_methods.py 58.33% 10 Missing ⚠️
...ns/experimental/rule_based_profiler/config/base.py 30.76% 9 Missing ⚠️
...omain_builder/categorical_column_domain_builder.py 18.18% 9 Missing ⚠️
...tions/execution_engine/sparkdf_execution_engine.py 14.28% 6 Missing ⚠️
great_expectations/expectations/expectation.py 89.79% 5 Missing ⚠️
...filer/domain_builder/column_pair_domain_builder.py 28.57% 5 Missing ⚠️
...le_based_profiler/domain_builder/domain_builder.py 20.00% 4 Missing ⚠️
...p_metric_provider/multicolumn_condition_partial.py 0.00% 3 Missing ⚠️
...ap_metric_provider/multicolumn_function_partial.py 0.00% 3 Missing ⚠️
... and 23 more

❗ There is a different number of reports uploaded between BASE (58e2823) and HEAD (d329f21). Click for more details.

HEAD has 73 uploads less than BASE
Flag BASE (58e2823) HEAD (d329f21)
3.11 3 1
3.9 3 1
3.10 3 1
3.12 2 1
3.9 clickhouse 2 0
3.12 big 2 0
3.9 big 2 0
3.12 aws_deps 2 0
3.9 aws_deps 2 0
3.9 filesystem 2 0
3.9 spark_connect 2 0
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 2 0
3.12 filesystem 2 0
3.12 spark_connect 2 0
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 2 0
docs-basic 1 0
docs-creds-needed 1 0
3.9 mysql 2 0
docs-spark 1 0
3.12 mysql 2 0
3.9 mssql 2 0
3.9 postgresql 2 0
3.12 mssql 2 0
3.12 postgresql 2 0
3.9 trino 1 0
3.12 trino 1 0
3.9 spark 1 0
cloud 1 0
3.12 spark 1 0
3.9 databricks 1 0
3.9 snowflake 1 0
3.12 databricks 1 0
3.12 snowflake 1 0
3.11 clickhouse 1 0
3.10 clickhouse 1 0
3.11 big 1 0
3.10 big 1 0
3.10 aws_deps 1 0
3.11 aws_deps 1 0
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds 1 0
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds 1 0
3.11 filesystem 1 0
3.10 filesystem 1 0
3.10 spark_connect 1 0
3.11 spark_connect 1 0
3.11 mysql 1 0
3.10 mysql 1 0
3.11 mssql 1 0
3.11 postgresql 1 0
3.10 postgresql 1 0
3.10 mssql 1 0
3.11 trino 1 0
3.10 trino 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10594       +/-   ##
============================================
- Coverage    80.26%   67.94%   -12.33%     
============================================
  Files          461      459        -2     
  Lines        40013    40008        -5     
============================================
- Hits         32115    27182     -4933     
- Misses        7898    12826     +4928     
Flag Coverage Δ
3.10 67.91% <88.61%> (-0.02%) ⬇️
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 clickhouse ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark_connect ?
3.10 trino ?
3.11 67.91% <88.61%> (+<0.01%) ⬆️
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 clickhouse ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark_connect ?
3.11 trino ?
3.12 67.93% <88.61%> (+0.01%) ⬆️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.12 aws_deps ?
3.12 big ?
3.12 databricks ?
3.12 filesystem ?
3.12 mssql ?
3.12 mysql ?
3.12 postgresql ?
3.12 snowflake ?
3.12 spark ?
3.12 spark_connect ?
3.12 trino ?
3.9 67.96% <88.61%> (+<0.01%) ⬆️
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 clickhouse ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 spark_connect ?
3.9 trino ?
cloud ?
docs-basic ?
docs-creds-needed ?
docs-spark ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant