Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Enable mostly as an expectation parameter #10656

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

anthonyburdi
Copy link
Member

@anthonyburdi anthonyburdi commented Nov 12, 2024

Add SuiteParameterDict to MostlyField

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 11a513a
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6733b6c31c02c20008fe3574

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.15%. Comparing base (5218278) to head (11a513a).

✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (5218278) and HEAD (11a513a). Click for more details.

HEAD has 73 uploads less than BASE
Flag BASE (5218278) HEAD (11a513a)
3.9 2 1
3.11 2 1
3.10 2 1
3.12 2 1
3.9 clickhouse 2 0
3.9 big 2 0
3.12 big 2 0
3.12 aws_deps 2 0
3.9 aws_deps 2 0
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 2 0
3.9 spark_connect 2 0
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 2 0
3.9 filesystem 2 0
3.12 filesystem 2 0
docs-spark 1 0
3.12 spark_connect 2 0
3.9 mysql 2 0
docs-basic 1 0
3.12 mysql 2 0
docs-creds-needed 1 0
3.9 mssql 2 0
3.12 mssql 2 0
3.12 postgresql 2 0
3.9 trino 2 0
3.12 trino 2 0
3.9 postgresql 2 0
cloud 1 0
3.9 spark 2 0
3.12 spark 1 0
3.9 databricks 1 0
3.9 snowflake 1 0
3.12 databricks 1 0
3.12 snowflake 1 0
3.11 clickhouse 1 0
3.10 clickhouse 1 0
3.11 aws_deps 1 0
3.11 big 1 0
3.10 big 1 0
3.10 aws_deps 1 0
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds 1 0
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds 1 0
3.10 filesystem 1 0
3.11 filesystem 1 0
3.11 spark_connect 1 0
3.11 mysql 1 0
3.10 mysql 1 0
3.10 mssql 1 0
3.11 mssql 1 0
3.10 postgresql 1 0
3.10 spark_connect 1 0
3.11 postgresql 1 0
3.10 trino 1 0
3.11 trino 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10656       +/-   ##
============================================
- Coverage    80.43%   68.15%   -12.28%     
============================================
  Files          462      460        -2     
  Lines        40098    40096        -2     
============================================
- Hits         32254    27329     -4925     
- Misses        7844    12767     +4923     
Flag Coverage Δ
3.10 68.14% <ø> (ø)
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 clickhouse ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark_connect ?
3.10 trino ?
3.11 68.14% <ø> (ø)
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 clickhouse ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark_connect ?
3.11 trino ?
3.12 68.13% <ø> (-0.02%) ⬇️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.12 aws_deps ?
3.12 big ?
3.12 databricks ?
3.12 filesystem ?
3.12 mssql ?
3.12 mysql ?
3.12 postgresql ?
3.12 snowflake ?
3.12 spark ?
3.12 spark_connect ?
3.12 trino ?
3.9 68.18% <ø> (ø)
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 clickhouse ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 spark_connect ?
3.9 trino ?
cloud ?
docs-basic ?
docs-creds-needed ?
docs-spark ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anthonyburdi anthonyburdi changed the title Add SuiteParameterDict to MostlyField [MAINTENANCE] Enable mostly as an expectation parameter Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant