[MAINTENANCE] Databricks data type expectation tests #10734
+166
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10734 +/- ##
===========================================
- Coverage 80.53% 80.50% -0.03%
===========================================
Files 463 463
Lines 40233 40233
===========================================
- Hits 32401 32391 -10
- Misses 7832 7842 +10 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tyler-hoffman
approved these changes
Dec 4, 2024
| @@ -14,6 +14,8 @@ | |||
| from tests.integration.test_utils.data_source_config import SnowflakeDatasourceTestConfig | |||
| from tests.integration.test_utils.data_source_config.snowflake import SnowflakeBatchTestSetup | |||
|
|
|||
| pytestmark = pytest.mark.snowflake | |||
There was a problem hiding this comment.
that's the good stuff!
| ) | ||
| assert result.success | ||
|
|
||
| @pytest.mark.xfail( |
There was a problem hiding this comment.
is there a ticket for this?
There was a problem hiding this comment.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke lint(usesruff format+ruff check)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!