Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Ensure datetime.time can be serialized to JSON #10795

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

wookasz
Copy link
Contributor

@wookasz wookasz commented Dec 19, 2024

Adds datetime.time handling to the serialization code in utils. datetime.time is now serializable, and serialization is performed by converting it to its ISO format string.

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit ef8ca91
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6763909f430f130008d9293c

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (5e11e7c) to head (ef8ca91).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10795   +/-   ##
========================================
  Coverage    80.70%   80.70%           
========================================
  Files          464      464           
  Lines        40371    40371           
========================================
  Hits         32581    32581           
  Misses        7790     7790           
Flag Coverage Δ
3.10 69.98% <100.00%> (+<0.01%) ⬆️
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 clickhouse ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark_connect ?
3.11 69.98% <100.00%> (ø)
3.11 aws_deps ?
3.11 big ?
3.11 clickhouse ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark_connect ?
3.12 69.98% <100.00%> (+<0.01%) ⬆️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.41% <100.00%> (ø)
3.12 aws_deps 46.22% <50.00%> (ø)
3.12 big 54.75% <100.00%> (ø)
3.12 bigquery 48.51% <50.00%> (ø)
3.12 databricks 50.28% <50.00%> (+<0.01%) ⬆️
3.12 filesystem 62.68% <100.00%> (ø)
3.12 mssql 51.28% <50.00%> (ø)
3.12 mysql 51.69% <50.00%> (ø)
3.12 postgresql 54.42% <100.00%> (ø)
3.12 snowflake 51.10% <50.00%> (ø)
3.12 spark 57.69% <50.00%> (ø)
3.12 spark_connect 46.51% <50.00%> (ø)
3.12 trino 52.25% <100.00%> (ø)
3.9 70.01% <100.00%> (+<0.01%) ⬆️
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.41% <100.00%> (ø)
3.9 aws_deps 46.24% <50.00%> (ø)
3.9 big 54.77% <100.00%> (ø)
3.9 bigquery 48.50% <50.00%> (ø)
3.9 clickhouse 43.12% <0.00%> (ø)
3.9 databricks 50.28% <50.00%> (ø)
3.9 filesystem 62.68% <100.00%> (ø)
3.9 mssql 51.26% <50.00%> (ø)
3.9 mysql 51.67% <50.00%> (ø)
3.9 postgresql 54.40% <100.00%> (ø)
3.9 snowflake 51.10% <50.00%> (ø)
3.9 spark 57.66% <50.00%> (ø)
3.9 spark_connect 46.52% <50.00%> (ø)
3.9 trino 52.23% <100.00%> (ø)
cloud 0.00% <0.00%> (ø)
docs-basic 54.07% <100.00%> (ø)
docs-creds-needed 52.95% <100.00%> (ø)
docs-spark 52.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant