-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gather more build information and improve version string #126
Conversation
I tried it with local tags and observed that this results in
or
which I think is great! |
Is it expected that I would see things like |
Yes, that was the intent and I tested it too; I should have mentioned that.
It's expected, but annoying. It happens because we depend on cross-platform crates that depend on the union of all their dependencies for each platform. Originally, they had no option but to do this. Later, Cargo gained support for target-specific dependencies. But some projects haven't been updated to use that feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! The additional info is excellent!
Actually, looking a bit more closely that may not be the reason for the extraneous dependencies. See lukaslueg/built#55. So we may be able to do better here. |
Updated to catch the license file for a dependency after fixing #127; no change to the diff of the main commit. |
This PR uses the
built
crate to gather additional build-time information which is reported in the--version
output and the About dialog.Fixes the failure to build without a
.git
directory, caused by #125.Output of
--version
when built with a.git
directory:Output when built without a
.git
directory:The
--dependencies
option can now be used along with--version
to print crate dependencies used. This is omitted by default as it generates a lot of output.The same information as above, as well as the dependency listing, is displayed in the About dialog.