-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make calls to get workflow_id only if send-data is set to true #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the status here?
If you need some action it would be good if you either make a comment or put somebody in as a reviewer.
- I think your code needs some more adapation. The variable workflow_id is not set when $send_data is not set. However, it is still used in the later code when passed to
create-and-add-meta.sh
Although this might not break stuff I would prefer not to have the script handle unset variables.
- A general recommendation here should be to set all scripts to
set -euo pipefail
.
Is there a reason why this is not the case?
Action here is that I need a bit more testing before I can merge this. Good catch on the create-and-add-meta.sh -> I agree that the scripts shouldn't handle unset variables and the testing is to double check this is the case. No real reason why they're not set to set -euo pipefail, will add it |
…fail for bash scripts
…but raising it would fail the script
…xed pythong previous_env logic to work with unbound variables
Eco-CI Output:
📈 Energy graph:
2.50 ┤ ╭╮
2.42 ┤ ││
2.35 ┤ ││
2.27 ┤ ││
2.19 ┤ ││
2.12 ┤ ││
2.04 ┤ ││
1.96 ┤ │╰─╮ ╭─
1.89 ┼╮╭─╮│ │ │
1.81 ┤││ ╰╯ ╰╮ │
1.73 ┤╰╯ ╰──╯
Watts over time |
Eco-CI Output:
📈 Energy graph:
2.57 ┤ ╭╮
2.49 ┤ ││
2.40 ┤ ││
2.32 ┤ ││
2.24 ┤ ││
2.15 ┤ ││
2.07 ┤ ││
1.99 ┤ ││ ╭─
1.90 ┤ ││╭╮ │
1.82 ┼╮ ╭─╯│││ ╭╯
1.73 ┤╰─╯ ╰╯╰──╯
Watts over time |
Eco-CI Output:
📈 Energy graph:
3.76 ┤╭╮
3.61 ┤││ ╭╮ ╭╮
3.45 ┤││ ││ ││
3.29 ┤││ ││ ││╭╮
3.14 ┤││ │╰╮ ││││
2.98 ┤││ │ │ ││││
2.83 ┤│╰╮ │ │ ││││
2.67 ┤│ │ │ │ ││││
2.52 ┤│ ╰╮│ │ ││││
2.36 ┼╯ ││ │ ╭╯│││
2.20 ┤ ╰╯ ╰─╯ ╰╯╰
Watts over time |
No description provided.