Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make calls to get workflow_id only if send-data is set to true #30

Merged
merged 22 commits into from
Oct 2, 2023

Conversation

dan-mm
Copy link
Contributor

@dan-mm dan-mm commented Jul 23, 2023

No description provided.

Copy link
Member

@ArneTR ArneTR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the status here?

If you need some action it would be good if you either make a comment or put somebody in as a reviewer.

  1. I think your code needs some more adapation. The variable workflow_id is not set when $send_data is not set. However, it is still used in the later code when passed to create-and-add-meta.sh

Although this might not break stuff I would prefer not to have the script handle unset variables.

  1. A general recommendation here should be to set all scripts to set -euo pipefail.

Is there a reason why this is not the case?

@dan-mm dan-mm self-assigned this Jul 25, 2023
@dan-mm
Copy link
Contributor Author

dan-mm commented Jul 25, 2023

Action here is that I need a bit more testing before I can merge this.

Good catch on the create-and-add-meta.sh -> I agree that the scripts shouldn't handle unset variables and the testing is to double check this is the case.

No real reason why they're not set to set -euo pipefail, will add it

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Eco-CI Output:

Label 🖥 avg. CPU utilization [%] 🔋 Total Energy [Joules] 🔌 avg. Power [Watts] Duration [Seconds]
Total Run 7.98273 26.6121 1.90087 23
Measurement #1 8.52625 13.6162 1.94517 8
Sleep #2 7.825 12.9959 1.85656 9

📈 Energy graph:

 
 2.50 ┤    ╭╮
 2.42 ┤    ││
 2.35 ┤    ││
 2.27 ┤    ││
 2.19 ┤    ││
 2.12 ┤    ││
 2.04 ┤    ││
 1.96 ┤    │╰─╮   ╭─
 1.89 ┼╮╭─╮│  │   │
 1.81 ┤││ ╰╯  ╰╮  │
 1.73 ┤╰╯      ╰──╯
       Watts over time

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Eco-CI Output:

Label 🖥 avg. CPU utilization [%] 🔋 Total Energy [Joules] 🔌 avg. Power [Watts] Duration [Seconds]
Total Run 6.11143 26.2512 1.87509 22
Measurement #1 8.22875 13.2595 1.89422 8
Sleep #2 7.3125 12.9917 1.85595 9

📈 Energy graph:

 
 2.57 ┤    ╭╮
 2.49 ┤    ││
 2.40 ┤    ││
 2.32 ┤    ││
 2.24 ┤    ││
 2.15 ┤    ││
 2.07 ┤    ││
 1.99 ┤    ││     ╭─
 1.90 ┤    ││╭╮   │
 1.82 ┼╮ ╭─╯│││  ╭╯
 1.73 ┤╰─╯  ╰╯╰──╯
       Watts over time

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Eco-CI Output:

Label 🖥 avg. CPU utilization [%] 🔋 Total Energy [Joules] 🔌 avg. Power [Watts] Duration [Seconds]
Total Run 13.0261 38.2259 2.73042 25
Measurement #1 11.355 20.1502 2.87859 9
Sleep #2 9.75 18.0757 2.58224 9

📈 Energy graph:

 
 3.76 ┤╭╮
 3.61 ┤││  ╭╮   ╭╮
 3.45 ┤││  ││   ││
 3.29 ┤││  ││   ││╭╮
 3.14 ┤││  │╰╮  ││││
 2.98 ┤││  │ │  ││││
 2.83 ┤│╰╮ │ │  ││││
 2.67 ┤│ │ │ │  ││││
 2.52 ┤│ ╰╮│ │  ││││
 2.36 ┼╯  ││ │ ╭╯│││
 2.20 ┤   ╰╯ ╰─╯ ╰╯╰
       Watts over time

@dan-mm dan-mm merged commit ed1c64e into main Oct 2, 2023
3 checks passed
@dan-mm dan-mm deleted the no-workflow-id-call branch October 2, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants