Improve implementations, code style, and tests#33
Merged
austinkline merged 4 commits intogreen-goo-dao:mainfrom Nov 3, 2024
Merged
Improve implementations, code style, and tests#33austinkline merged 4 commits intogreen-goo-dao:mainfrom
austinkline merged 4 commits intogreen-goo-dao:mainfrom
Conversation
6 tasks
bluesign
reviewed
Oct 25, 2024
bluesign
reviewed
Oct 25, 2024
bjartek
reviewed
Oct 29, 2024
bluesign
approved these changes
Oct 29, 2024
Contributor
Author
|
@bjartek @austinkline Would be great to get this merged, so we can update the Cadence Source Compatibility Suite, which currently uses a fork with these changes: https://github.com/onflow/cadence/blob/master/compat/suite/green-goo-dao-flow-utils.yaml |
austinkline
approved these changes
Nov 3, 2024
Contributor
austinkline
left a comment
There was a problem hiding this comment.
LGTM, @bjartek any objections?
Contributor
|
No |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.contains) and functionality (e.g.InclusiveRange) built into Cadence now. In some cases this makes the code much more efficient, e.g.InclusiveRangedoes not allocate a whole array of indices like before