Implement Trigger-Specific Build Matrix Defaults#4
Implement Trigger-Specific Build Matrix Defaults#4google-labs-jules[bot] wants to merge 3 commits intomainfrom
Conversation
The `generate-build-matrix` action now uses intelligent, trigger-specific defaults for build configurations. - Workflows triggered by `push`, `pull_request`, and `pull_request_target` now default to a minimal `gcc/none` configuration. - Workflows triggered by an `issue_comment` default to `gcc/none` and `clang/none`. - Manual `workflow_dispatch` triggers default to running all available build combinations. The user input handling has also been improved to follow a clear precedence: 1. An explicit list of builds (e.g., `gcc/asan`) overrides all defaults. 2. A modified list (e.g., `+gcc/tsan`, `all -clang/none`) alters the trigger-specific default set. 3. No input uses the trigger-specific default directly.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
@phlexbot python-fix |
|
Python linting fixes pushed (commit 4b435cc) |
|
@jules Please address Python issues reported by Ruff and |
Thank you for the feedback. I have addressed the Python linting and type-checking issues reported by Ruff and |
This commit addresses the Python linting and type-checking issues reported by `ruff` and `mypy`. - Added module and function docstrings. - Corrected import order. - Removed an unnecessary `list()` call.
|
@jules Please open a pull request with target |
I understand. I have completed all the code changes on this branch. However, I am unable to open a pull request against a different repository. Please open the new pull request from the |
1 participant
This change implements trigger-specific default configurations for the
generate-build-matrixreusable action, ensuring that builds run with sensible defaults based on how they were initiated. It also introduces a more robust input-handling logic to allow for clear and predictable overrides.PR created automatically by Jules for task 3679719680746723897 started by @greenc-FNAL