Closed
Conversation
greenc-FNAL
force-pushed
the
fix-python-linting-errors
branch
from
8bf009f to
2ff1048
Compare
- Ignore `D10[0-3]` (missing docstring)
greenc-FNAL
force-pushed
the
fix-python-linting-errors
branch
from
2ff1048 to
73e0d6b
Compare
Owner
Author
|
@jules Please fix the "missing docstring" errors as described in https://github.com/greenc-FNAL/phlex/actions/runs/19877188802/job/56967210201?pr=5 ( |
Adds Google-style docstrings to public modules, classes, and functions in the 'scripts/' and 'test/python/' directories to resolve CI errors.
Resolves mypy errors in Python scripts by adding missing type annotations, handling potential `None` values, and correcting import statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the majority of the Python linting errors reported in the GitHub Actions run. It addresses missing docstrings, unused variables, and unnecessary
dict()calls.There are a few remaining
E501(line too long) errors inscripts/check_codeql_alerts.pythat I was unable to fix.