Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-filter for sources.yaml #133

Merged
merged 1 commit into from
Aug 7, 2024
Merged

remove-filter for sources.yaml #133

merged 1 commit into from
Aug 7, 2024

Conversation

cgreene
Copy link
Member

@cgreene cgreene commented Aug 7, 2024

Testing what this looks like

Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://greenelab.github.io/greenelab.com/preview/pr-133/
on branch gh-pages at 2024-08-07 05:01 UTC

@cgreene
Copy link
Member Author

cgreene commented Aug 7, 2024

@vincerubinetti this picks up a few things I missed. Is it possible to filter by journal (e.g., the figshare and zenodo records) akin to the way we were filtering by file before?

Also, there are a few broken images for the Figshare datasets - not sure what's happening there but it's rendering HTML on it.

@vincerubinetti
Copy link
Contributor

vincerubinetti commented Aug 7, 2024

You can filter by anything you want using regex, but you might want to wait until I've made this upstream change for it to be a little easier:

greenelab/lab-website-template#272

Also I noticed that HTML bug and have made an upstream fix, also coming in v1.3.0. It's because the title has a double quote in it, which prematurely closes an html attribute, which messes everything else up. As a stop gap you can add | xml_escape in the citation component wherever title is being used:

greenelab/lab-website-template@b33e0e4

@cgreene
Copy link
Member Author

cgreene commented Aug 7, 2024

Ok - I don't mind merging what's here and then adding the filter when 272 lands - this is quite a bit more complete & demonstrates that I definitely missed some key papers. :)

@cgreene cgreene merged commit 3cf174e into main Aug 7, 2024
6 checks passed
@cgreene cgreene deleted the cgreene-patch-2 branch August 7, 2024 19:08
@cgreene
Copy link
Member Author

cgreene commented Aug 7, 2024

Also the xml_escape filter will be nice when it lands - at this point unless someone compromises ORCID to inject javascript, we should be good - it's far enough down the page I doubt anyone will encounter it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants