Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial upload #1

Merged
merged 10 commits into from
Mar 24, 2020
Merged

initial upload #1

merged 10 commits into from
Mar 24, 2020

Conversation

vincerubinetti
Copy link
Collaborator

@vincerubinetti vincerubinetti commented Mar 5, 2020

  • replaces hcluster.js by @cmpolis
  • in general, faster and more efficient than hcluster.js, with equivalent functionality
  • more modern javascript syntax to be cleaner and more readable

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@dongbohu dongbohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/hclust.js Outdated Show resolved Hide resolved
src/hclust.js Outdated Show resolved Hide resolved
test/performance.html Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@vincerubinetti
Copy link
Collaborator Author

Added a github actions workflow to publish package to npm. Don't merge until these two questions are answered:
mikeal/merge-release#13 (comment)
mikeal/merge-release#9 (comment)

@vincerubinetti
Copy link
Collaborator Author

vincerubinetti commented Mar 11, 2020

@dongbohu @dhimmel Could you take a quick look at this commit regarding github actions, and this specific action.

I created a greenelab org on npm and created an auth token, and added it as a secret to this repo under NPM_AUTH_TOKEN. But I don't have to specify the org in the gh-actions workflow? I guess the auth token is enough to identify which org to publish the package to.

Copy link
Member

@cgreene cgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice! I had just a few minor comments.

README.md Outdated Show resolved Hide resolved
LICENSE Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@dhimmel dhimmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the action part looks good to me!

.github/workflows/npm-publish.yml Outdated Show resolved Hide resolved
@dongbohu
Copy link

The git action part looks good to me too.

@vincerubinetti vincerubinetti merged commit 91c5b50 into master Mar 24, 2020
@vincerubinetti vincerubinetti deleted the initial-upload branch March 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants