-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #306
base: main
Are you sure you want to change the base?
Spelling #306
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ Before sending your pull requests, make sure you followed this list. | |
|
||
## Development Environment | ||
|
||
The contribution to this project requires setting up a development | ||
Contribution to this project requires setting up a development | ||
environment. The following steps allow developers to test their | ||
setup using local source code. | ||
|
||
|
@@ -34,7 +34,7 @@ mkdir -p ~/tmpdev | |
cd ~/tmpdev | ||
``` | ||
|
||
Second, fork the following repositories in Github into to your own Github | ||
Second, fork the following repositories in GitHub into to your own GitHub | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. brand |
||
handle, e.g. `anonymous`: | ||
|
||
* `https://github.com/greenpau/caddy-security` => `https://github.com/anonymous/caddy-security` | ||
|
@@ -57,7 +57,7 @@ make dep | |
|
||
Next, modify `go.mod` in `github.com/greenpau/caddy-security`. Include | ||
`replace` directives to instruct `go` using local directories, as opposed | ||
to follow Github versions. | ||
to follow GitHub versions. | ||
|
||
Note: the referenced versions must match. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,7 +82,6 @@ qtest: covdir | |
@time richgo test -v -coverprofile=.coverage/coverage.out -run TestParseCaddyfileSingleSignOnProvider ./*.go | ||
@#time richgo test -v -coverprofile=.coverage/coverage.out -run TestParseCaddyfileCredentials ./*.go | ||
@#time richgo test -v -coverprofile=.coverage/coverage.out -run TestParseCaddyfileMessaging ./*.go | ||
@#time richgo test -v -coverprofile=.coverage/coverage.out -run TestParseCaddyfileIdentit* ./*.go | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Line 81 above had nearly identical content and there doesn't seem to be anything that would match this that didn't match that. |
||
@#time richgo test -v -coverprofile=.coverage/coverage.out -run TestParseCaddyfileAuthentication ./*.go | ||
@#time richgo test -v -coverprofile=.coverage/coverage.out -run TestParseCaddyfileAuthorization ./*.go | ||
@#go test -v -coverprofile=.coverage/coverage.out -run TestParseCaddyfile ./*.go | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,13 +15,14 @@ | |
package security | ||
|
||
import ( | ||
"os" | ||
"strings" | ||
|
||
"github.com/caddyserver/caddy/v2" | ||
"github.com/caddyserver/caddy/v2/caddyconfig/caddyfile" | ||
"github.com/greenpau/caddy-security/pkg/util" | ||
"github.com/greenpau/go-authcrunch/pkg/authn" | ||
"github.com/greenpau/go-authcrunch/pkg/authn/ui" | ||
"io/ioutil" | ||
"strings" | ||
) | ||
|
||
func parseCaddyfileAuthPortalUI(h *caddyfile.Dispenser, repl *caddy.Replacer, portal *authn.PortalConfig, rootDirective string) error { | ||
|
@@ -131,7 +132,7 @@ func parseCaddyfileAuthPortalUI(h *caddyfile.Dispenser, repl *caddy.Replacer, po | |
portal.UI.CustomJsPath = strings.ReplaceAll(args, "js ", "") | ||
case strings.HasPrefix(args, "html header path"): | ||
args = strings.ReplaceAll(args, "html header path ", "") | ||
b, err := ioutil.ReadFile(args) | ||
b, err := os.ReadFile(args) | ||
Comment on lines
-134
to
+135
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Go made me do it? |
||
if err != nil { | ||
return h.Errf("%s %s subdirective: %s %v", rootDirective, subDirective, args, err) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't precisely a spelling thing, it's more of a grammar thing... Anyway,
The
does the wrong thing here.