Ability to inject the authorization URL through the constructor #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefersonralmeida
commented
Mar 8, 2024
src/Provider/Azure.php
Outdated
| * @param array $collaborators | ||
| * @param string $urlAuthorize Base url for authorization. | ||
| */ | ||
| public function __construct(array $options = [], array $collaborators = [], string $urlAuthorize = 'https://login.microsoftonline.com') |
There was a problem hiding this comment.
Just letting clear that this syntax could be much cleaner, using constructor property promotion, but I saw that the package composer file requires support to PHP 7 (property promotion is only supported by php 8.x).
|
Great - thanks! 😃 Just need to break the constructor properties up into single lines to conform to the PHP CodeSniffer rules. When that's fixed, I'll merge it! |
…he PHP CodeSniffer rules
|
It's done @greew , sorry for the delay, I was out on a trip last week. |
|
Hey @greew , can we merge it? |
|
Yeah - Thank you for your work! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just added the $urlAuthorize property as a optional constructor parameter.
It fixes this issue.