Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Commit

Permalink
Remove netrc file, depend on HEROKU_API_KEY
Browse files Browse the repository at this point in the history
  • Loading branch information
gregburek committed Mar 28, 2014
1 parent d967348 commit 84e1289
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 31 deletions.
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ Example usage:

$ heroku config:add BUILDPACK_URL=https://github.com/ddollar/heroku-buildpack-multi.git

$ heroku config:add [email protected]

$ heroku config:add HEROKU_TOOLBELT_API_PASSWORD=`heroku auth:token`
$ heroku config:add HEROKU_API_KEY=`heroku auth:token`
$ heroku config:unset HEROKU_HOST

$ cat .buildpacks
https://github.com/heroku/heroku-buildpack-toolbelt.git
Expand Down
18 changes: 0 additions & 18 deletions bin/compile
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,6 @@ function error() {
exit 1
}

function indent() {
c='s/^/ /'
case $(uname) in
Darwin) sed -l "$c";;
*) sed -u "$c";;
esac
}

function package_download() {
engine="$1"
version="$2"
location="$3"

mkdir -p $location

This comment has been minimized.

Copy link
@ideadapt

ideadapt Apr 17, 2014

Hi Greg
I also had this issue: #5
Than I tried to install your no-netrc branch. But installation failed with mkdir: missing operand. In my opinion this makes perfect sense, since $location is never defined. Also I think there is one } too much.

I tried to fix it by myself but I have really no clue how this whole think is ought to work :/

package="https://${S3_BUCKET}.s3.amazonaws.com/$engine-$version.tgz"
curl $package -s -o - | tar xzf - -C $location
Expand All @@ -61,9 +48,4 @@ fi
mv heroku-client/* .
rmdir heroku-client

echo "-----> Moving the netrc generation script into app/.profile.d"
mkdir -p $BUILD_DIR/.profile.d
cp "$BUILDPACK_DIR/bin/gen-netrc.sh" $BUILD_DIR/.profile.d/
chmod +x $BUILD_DIR/.profile.d/gen-netrc.sh

echo "-----> heroku toolbelt installation done"
10 changes: 0 additions & 10 deletions bin/gen-netrc.sh

This file was deleted.

1 comment on commit 84e1289

@rjst
Copy link

@rjst rjst commented on 84e1289 Oct 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ideadapt,

Had the same issue as you, check out if this pull request may help - #10

Ricardo

Please sign in to comment.