Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update selectors #27

Merged
merged 1 commit into from
Oct 28, 2019
Merged

update selectors #27

merged 1 commit into from
Oct 28, 2019

Conversation

Procyon-b
Copy link
Contributor

@Procyon-b Procyon-b commented Sep 27, 2019

[Closes #26 –Ed.]

2 selectors have been added.

[type=""] is for a page where the userscript failed, but has since been fixed. It happened once, so it's a good idea to add it.

[type*="search" i] could replace [type="search" i], but I left the old value. It can be simplified in a future release after double-checking that the wildcard doesn't fail on some circumstances.

@Procyon-b
Copy link
Contributor Author

Possible enhancements: #28

@cxw42
Copy link
Collaborator

cxw42 commented Oct 4, 2019

@Procyon-b thank you! I'll take a look. The beginning of Hacktoberfest has been very crazy :) .

If you would like an additional Hacktoberfest credit, please feel free to close this PR and open a fresh one with the same changes :D .

@cxw42
Copy link
Collaborator

cxw42 commented Oct 28, 2019

  • Works for me on the two sites listed in a couple thai sites getting through #26!
  • I did a spot check of a few sites from the Wiki, both mobile and desktop versions. I didn't see any failures. It reminded me that, as the list grows, Add tests #7 will be increasingly important. But I'm still not sure how to implement that one! :/

@cxw42 cxw42 merged commit e8b215c into gregsadetsky:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a couple thai sites getting through
2 participants