Skip to content

Fix/portal webappform #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
digmunhoz merged 2 commits into from
Feb 27, 2026
Merged

Fix/portal webappform #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2b3dcf
fix(portal): guard command.trim when settings.command is array in Web…
digmunhoz Feb 26, 2026
a0b9074
fix(portal): fix tsc errors in WebappForm command check
digmunhoz Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion portal/src/components/applications/WebappForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,13 @@ export function WebappForm({ settings, onChange, url, onUrlChange, hasGatewayApi
const hasAdvancedChanges = () => {
const hasEnvs = settings.envs && settings.envs.length > 0
const hasSecrets = settings.secrets && settings.secrets.length > 0
const hasCommand = settings.command && settings.command.trim() !== ''
const hasCommand = (() => {
const cmd: unknown = settings.command
if (cmd == null) return false
if (typeof cmd === 'string') return cmd.trim() !== ''
if (Array.isArray(cmd)) return cmd.length > 0 && cmd.some((c: unknown) => String(c).trim() !== '')
return false
})()
const hasCustomCpu = settings.cpu !== undefined && settings.cpu !== 0.5
const hasCustomMemory = settings.memory !== undefined && settings.memory !== 512
return hasEnvs || hasSecrets || hasCommand || hasCustomCpu || hasCustomMemory
Expand Down
Loading