Skip to content

Strengthen/bug-fix compute_facet_owners #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amartinhuertas merged 15 commits into from
Apr 30, 2026
+48 −4
Merged

Strengthen/bug-fix compute_facet_owners #1291

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b9f71c7
Strengthen compute_facet_owners(...) so that the owner of a facet
amartinhuertas Apr 29, 2026
dd59203
Updated NEWS and bumped patch version
amartinhuertas Apr 29, 2026
80809b3
Update src/FESpaces/Pullbacks.jl
amartinhuertas Apr 29, 2026
b5e0373
Update src/FESpaces/Pullbacks.jl
amartinhuertas Apr 29, 2026
3b3de16
Better implementation of compute_facet_owners
JordiManyer Apr 29, 2026
0a1d952
Adding a couple of broken tests to DivConformingFESpacesTests.
amartinhuertas Apr 29, 2026
a363ba1
Added PR # to NEWS.md
amartinhuertas Apr 29, 2026
6b06b5c
Do not use rand in the added broken tests, as suggested by CoPilot
amartinhuertas Apr 29, 2026
ba3cbd4
Update test/FESpacesTests/DivConformingFESpacesTests.jl
amartinhuertas Apr 30, 2026
e6138a4
Replaced first by maximum as the default value for select_nbor opt arg
amartinhuertas Apr 30, 2026
745caea
Merge branch 'add_broken_test_normal_sign' of github.com:gridap/Grida…
amartinhuertas Apr 30, 2026
14751b0
Converted broken tests to regular tests as this branch solves the
amartinhuertas Apr 30, 2026
af5ee78
Apply suggestion from @Copilot
amartinhuertas Apr 30, 2026
8822682
Do not bump patch version yet
amartinhuertas Apr 30, 2026
cdef184
Merge branch 'bug_fix_compute_facet_owners' of github.com:gridap/Grid…
amartinhuertas Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Make `compute_facet_owners(...)` more flexible, allowing the user to provide a function to select the owner from neighboring cells. Since PR[#1291](https://github.com/gridap/Gridap.jl/pull/1291).

## [0.20.5] - 2026-04-28

Comment thread
amartinhuertas marked this conversation as resolved.
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Gridap"
uuid = "56d4f2e9-7ea1-5844-9cf6-b9c51ca7ce8e"
authors = ["Santiago Badia <santiago.badia@monash.edu>", "Francesc Verdugo <f.verdugo.rojano@vu.nl>", "Alberto F. Martin <alberto.f.martin@anu.edu.au>"]
version = "0.20.5"
version = "0.20.6"

[deps]
AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"
Expand Down
7 changes: 3 additions & 4 deletions src/FESpaces/Pullbacks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,21 +188,20 @@ function evaluate!(cache,k::NormalSignMap,reffe,facet_own_dofs,cell)
return Diagonal(dof_sign)
end

function compute_facet_owners(model::DiscreteModel{Dc}) where {Dc}
function compute_facet_owners(model::DiscreteModel{Dc}, select_nbor=first) where {Dc}
Comment thread
amartinhuertas marked this conversation as resolved.
Outdated
topo = get_grid_topology(model)
facet_to_cell = get_faces(topo, Dc-1, Dc)

nfacets = num_faces(topo, Dc-1)
owners = Vector{Int32}(undef, nfacets)
for facet in 1:nfacets
facet_cells = view(facet_to_cell, facet)
owners[facet] = first(facet_cells)
@check !isempty(facet_cells) "Facet $facet has no adjacent cells"
owners[facet] = select_nbor(facet_cells)
Comment thread
amartinhuertas marked this conversation as resolved.
Outdated
end

return owners
end


#################
# DOFScalingMap #
#################
Expand Down
Loading