Automatically generate type definition files during npm run build #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thank you for the wonderful library!
While using midi-writer-js in TypeScript, I noticed that some methods were not being auto-completed, so I created this PR.
Track.controllerChangeand others are not listed.By adjusting tsconfig.json, it is possible to automatically output d.ts files under build/types when running npm run build, so I have changed it to automatically output at build time.
With this PR method, type definition files will be output to build/types and browser/types when running npm run build.
I believe this may result in a change in the project's policy, so please consider it.
Screenshots
As far as I have reflected the changes in node_modules/midi-writer-js of my project, I have confirmed that
Track.controllerChangeis also auto-completed by this method.