Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelization unnecessary external calls fix #126

Merged
merged 50 commits into from
Feb 19, 2025
Merged

Parallelization unnecessary external calls fix #126

merged 50 commits into from
Feb 19, 2025

Conversation

lmseidler
Copy link
Member

  • Stopped the program from calling unnecessary externals by checking stop_event before every external call in iterative_optimization
  • Added some comments to better understand the current workings of the parallelization

lmseidler and others added 30 commits January 14, 2025 16:05
@lmseidler
initial work
229727a
@lmseidler
new parallelization preliminary done
0069a6e
@lmseidler
small fix in tests
0534777
@lmseidler
commented unnecessary code
ef08fe5
@lmseidler
updated construction sites
872fd2e
@lmseidler
hopefully fixed parallelization
e2b0a51
@lmseidler
small test fix
3383173
@lmseidler
initial work
6e87a19
@lmseidler
new parallelization preliminary done
832f0ed
@lmseidler
small fix in tests
f4c02a8
@lmseidler
commented unnecessary code
42c3c41
@lmseidler
updated construction sites
b49b3f8
@lmseidler
hopefully fixed parallelization
c27dcae
@lmseidler
small test fix
5183a62
@lmseidler
Merge pull request #1 from lmseidler/parallel
42fcfca 
Parallel
@lmseidler
only print when verbosity > 0, otherwise nothing is printed (bad)
a65637f
@lmseidler
pre-commit fixes
256159c
@lmseidler
added ncores to config + implemented setting ncores for external prog…
f62ef53 
…rams
@lmseidler
fixed tests
c92cedc
@lmseidler
added check for number of cores available vs needed
7ab2873
@lmseidler
pre-commit
8494ba9
@lmseidler
test fix
c8df9b1
@lmseidler
Merge branch 'main' into main
47b9acc
@lmseidler
fixed tm implementation
57b6001
@lmseidler
updated main.py
c0a7855
@lmseidler
tqdm progress bar
493b92c
@lmseidler
updated dependencies
7da10e4
@lmseidler
mypy types import
6230638
@lmseidler
moved warnings in correct bracket
6d44b51
@lmseidler
updated default config toml
4bdff32
marcelmbn
marcelmbn requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@marcelmbn marcelmbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the code style type of things, looks great!

@marcelmbn
Copy link
Member

marcelmbn commented Feb 17, 2025 •
edited
Loading

And can you add the respective change to CHANGELOG.md?

EDIT: Done.

@marcelmbn
Copy link
Member

What do you think about my additions? For postprocessing we haven't checked if stop_event was set up to now, but this is the most time-critical step.

@lmseidler
Copy link
Member Author

this should finally also be merged with the dev/gp3_ipea branch

@marcelmbn
Copy link
Member

this should finally also be merged with the dev/gp3_ipea branch

Agree!
Do you agree with my changes introduced in the latest commit?

@lmseidler
Copy link
Member Author

looks good to me

@marcelmbn marcelmbn merged commit 0ce205a into grimme-lab:main Feb 19, 2025
11 checks passed
@marcelmbn marcelmbn mentioned this pull request Feb 19, 2025
Merged
marcelmbn added a commit that referenced this pull request Feb 19, 2025
@marcelmbn
Merge pull request #127 from marcelmbn/dev/gp3_ipea
8af8c93 
- include PRs: #126, #125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelmbn marcelmbn marcelmbn approved these changes

@jonathan-schoeps jonathan-schoeps Awaiting requested review from jonathan-schoeps jonathan-schoeps is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmseidler @marcelmbn