Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added C-interface c_gcp_call #14

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

added C-interface c_gcp_call #14

wants to merge 4 commits into from

Conversation

jkn93
Copy link

@jkn93 jkn93 commented Jan 23, 2023

I've added a C/C++ wrapper to handle Fortrans weird 4-bit-booleans and strings.

Can be used with the following declaration (C++):

extern "C" void c_gcp_call(int* n, double* xyz, double* lat, int* iz, double* gcp_e, double* gcp_g, double* gcp_glat,
bool* dograd, bool* dohess, bool* pbc, const char* method, bool* echo, bool* parfile);

Cheers...

@awvwgk
Copy link
Member

awvwgk commented Jan 23, 2023

Can you add a C header with the signature as well?

Jörg Kussmann added 2 commits January 23, 2023 17:53
@jkn93
Copy link
Author

jkn93 commented Jan 23, 2023

added header file as well as one test (tests/c_api). I'm not sure how to integrate that since I usually don't use meson...

@jkn93
Copy link
Author

jkn93 commented Jan 23, 2023

Regarding the test-file:
I used the test-system of the R2SCAN-3c SI, but I didn't check the HF3c value.
Feel free to extend the tests...

@awvwgk awvwgk linked an issue Mar 4, 2023 that may be closed by this pull request
@TyBalduf
Copy link

@awvwgk would you be able to retrigger the CI checks? I was going to see if I could help clean up this pull request, but the errors from the last CI run have expired.

I was looking into using this library for a project and a C-api would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide C API
3 participants