Skip to content

chore(libraries): add new library probes for Gumbo, Image Codec, PugiXML, and UCharDet#1094

Closed
balazs-szucs wants to merge 1 commit intogrimmory-tools:developfrom
balazs-szucs:probes-native
Closed

chore(libraries): add new library probes for Gumbo, Image Codec, PugiXML, and UCharDet#1094
balazs-szucs wants to merge 1 commit intogrimmory-tools:developfrom
balazs-szucs:probes-native

Conversation

@balazs-szucs
Copy link
Copy Markdown
Member

Description

ONLY relevant after: #1090 otherwise it just fails CI.

This pull request extends the native library management system by adding support for several new native libraries. It introduces new enum values, probing logic, and availability-checking methods for these libraries, making it easier to detect and utilize them in the application.

Linked Issue

  • Added new native libraries to the Library enum: GUMBO, IMAGE_CODEC, PUGIXML, and UCHARDET in NativeLibraries.java.
  • Implemented probe logic for the new libraries in the static initializer of NativeLibraries.java, allowing the system to check if each library is available.
  • Added new public methods in NativeLibraries.java to check the availability of each new library (isGumboAvailable, isImageCodecAvailable, isPugixmlAvailable, isUchardetAvailable).
  • Exposed the new availability check methods through NativeLibraryManager.java, so other parts of the application can easily query library availability.

Changes

Manual Testing Steps

  1. it compiles, natives work

Screenshots (Optional)

Additional Context (Optional)

AI Disclosure

Checklist

  • This PR links and implements an accepted issue.
  • This PR is a single focused change.
  • There are new or updated tests validating this change.
  • I ran just ui check and just api check.
  • I have added screenshots if there were any UI changes.
  • I have disclosed any AI usage as per the organization AI Policy above.
  • I understand all of my submitted changes.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: b71a6f7d-af65-43b5-be18-1ca058575df8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant