chore(libraries): add new library probes for Gumbo, Image Codec, PugiXML, and UCharDet#1094
Closed
balazs-szucs wants to merge 1 commit intogrimmory-tools:developfrom
Closed
chore(libraries): add new library probes for Gumbo, Image Codec, PugiXML, and UCharDet#1094balazs-szucs wants to merge 1 commit intogrimmory-tools:developfrom
balazs-szucs wants to merge 1 commit intogrimmory-tools:developfrom
Conversation
…XML, and UCharDet
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ONLY relevant after: #1090 otherwise it just fails CI.
This pull request extends the native library management system by adding support for several new native libraries. It introduces new enum values, probing logic, and availability-checking methods for these libraries, making it easier to detect and utilize them in the application.
Linked Issue
Libraryenum:GUMBO,IMAGE_CODEC,PUGIXML, andUCHARDETinNativeLibraries.java.NativeLibraries.java, allowing the system to check if each library is available.NativeLibraries.javato check the availability of each new library (isGumboAvailable,isImageCodecAvailable,isPugixmlAvailable,isUchardetAvailable).NativeLibraryManager.java, so other parts of the application can easily query library availability.Changes
Manual Testing Steps
Screenshots (Optional)
Additional Context (Optional)
AI Disclosure
Checklist
just ui checkandjust api check.