-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
line 1728: [: -ne: unary operator expected #268
Comments
Good catch. That one slipped through.
Do you mean script wide? In that case, unless specifically handling an error, it all relies now in the general error handling:
The error handling in this specific case, this specific feature was an oversight. Related source code:
Condition |
Yeah, so I guess that's what i mean: that wasn't made explicit in the patch, so we're left guessing what the plan is.
oh yeah, that seems simple enough... |
We were using the old-style "RC" error checking. Now that has all been moved to a global error handler, so we need to move log parsing there as well. Closes: grml#268
something like #269 perhaps? |
in the latest release, grml-debootstrap yields the above warning. Line 1728 is:
grml-debootstrap/grml-debootstrap
Line 1728 in 1675ca6
... which seems pretty innocuous, but RC is actually never defined. It was ripped out in 9706bd9 (#262).
I don't quite understand how that patch was supposed to work, it seems to me it just completely removes error-checking here...
The text was updated successfully, but these errors were encountered: