Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix debootstrap error handler #269

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix debootstrap error handler #269

merged 1 commit into from
Jan 26, 2024

Conversation

anarcat
Copy link
Contributor

@anarcat anarcat commented Jan 23, 2024

We were using the old-style "RC" error checking. Now that has all been moved to a global error handler, so we need to move log parsing there as well.

Closes: #268

@anarcat anarcat mentioned this pull request Jan 23, 2024
Closed
@anarcat
fix debootstrap error handler
cfa1651 
We were using the old-style "RC" error checking. Now that has all been
moved to a global error handler, so we need to move log parsing there
as well.

Fixes: 9706bd9 (improved error handling, removed RC=$? noops, 2023-12-22)
Closes: grml#268
@adrelanos
Copy link
Contributor

LGTM

@mika mika merged commit 6c84cfc into grml:master Jan 26, 2024
39 of 40 checks passed
@mika
Copy link
Member

mika commented Jan 26, 2024

Thanks @anarcat for report and PR and @adrelanos for reviewing! 👍

@anarcat anarcat deleted the bugfix-268 branch January 26, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

line 1728: [: -ne: unary operator expected
3 participants
@anarcat @adrelanos @mika