improve error handling #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because these are now covered by the error_handler
No need to use both, `eend 1` and `bailout 1`. In these cases, only `bailout 1` is sufficient.
only delete `$MNTPOINT` if such a folder actually exists
only delete `$MNTPOINT` if such a folder actually exists
because these are now covered by the new error handling method
INITRD=No is also supported by other scripts
because it will not always work will not work in cases where /dev etc is still mounted inside the chroot
|
This is now tested with |
|
This was used to build Kicksecure and Whonix VM images. Seems stable. No issues. |
|
This seems to break in some situations, example: https://github.com/zeha/grml-debootstrap/actions/runs/6906107865/job/18790415343 If you rebase this branch on top of current master, it should also get an actions pipeline. |
|
I created a branch |
|
Seems a lot easier to rebase using github "Resolve conflicts" button than what I did locally:
(Which is a 3 way diff using meld.) A lot things I resolved manually I was wondering why git failed to merge this automatically. Any hints for a better process? |
This was referenced Nov 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Not yet tested. Will test soon.
My commit messages are more explanatory for the reviewer than useful in the git history of the master branch.
Due the difficulty and extensive scope of these changes, I won't be able to split this into different logical sets of changes. It was so extensive, I had to randomly start somewhere and adjust it step by step for the new error handler.
I would suggest to squash all of these commits into a single commit since functionality wise hopefully nothing changed, just the error handling was improved and the code simplified.
Fixes #224