Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shellcheck: fix some warnings, enable PR review #237

Closed
wants to merge 3 commits into from
Closed

Conversation

zeha
Copy link
Member

@zeha zeha commented Nov 11, 2023

Catch up with shellcheck 0.9.0, and enable shellcheck in PR workflows.

To improve shellcheck usage in chroot-script, add a stub file defining ARCH.

The shellcheck commit is very minimal. In particular it avoids moving/deduplicating code and/or any style changes.

Verify with:

$ shellcheck grml-debootstrap config tests/shellcheck-stub-debootstrap-variables

Catch up with shellcheck 0.9.0.

To improve shellcheck usage in chroot-script, add a stub file defining ARCH.

This commit is very minimal. In particular it avoids moving/deduplicating code
and/or any style changes.
@zeha zeha requested a review from mika November 11, 2023 11:37
This reports shellcheck output for *changed* lines. Preexisting problems are
not reported.
@zeha zeha changed the title shellcheck: fix some warnings shellcheck: fix some warnings, enable PR review Nov 12, 2023
@mika mika closed this Nov 17, 2023
@mika mika deleted the shellcheck branch November 17, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants