consistent umount #264
Merged
consistent umount #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkirk
added a commit
to jkirk/grml-debootstrap
that referenced
this pull request
Feb 2, 2024
try_umount() replaced all umount calls in PR grml#264. Unfortunately, the function is defined too late for a few of functions, especially for cleanup(), which fails with: -> Failed (rc=1) /sbin/grml-debootstrap: line 260: try_umount: command not found Unexpected non-zero exit code 127 in /sbin/grml-debootstrap /sbin/grml-debootstrap /sbin/grml-debootstrap /sbin/grml-debootstrap /sbin/grml-debootstrap at line 260 329 1107 1179 0 detected! last bash command: try_umount 3 "${MNTPOINT}"/boot/efi -> Failed (rc=1) /sbin/grml-debootstrap: line 260: try_umount: command not found Moved the try_umount above cleanup(). Closes: grml#271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #263
based on #262
Not sure if it is acceptable here to have one PR based on top of another.