-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement clean_chroot, #267
base: master
Are you sure you want to change the base?
Changes from 2 commits
221a31b
61db3a0
5f10d52
0b5fb7b
45ad22d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,14 @@ | |
last_bash_command="$BASH_COMMAND" | ||
echo "Unexpected non-zero exit code $last_exit_code in ${BASH_SOURCE[*]} at line ${BASH_LINENO[*]} detected! | ||
last bash command: $last_bash_command" | ||
## Check if "bailout" function is already available. | ||
if [ -r "$MNTPOINT/debootstrap/debootstrap.log" ] && \ | ||
[ -s "$MNTPOINT/debootstrap/debootstrap.log" ] ; then | ||
einfo "Presenting last ten lines of debootstrap.log:" | ||
tail -10 "${MNTPOINT}"/debootstrap/debootstrap.log | ||
einfo "End of debootstrap.log" | ||
fi | ||
## Check if "bailout" function is available. | ||
## This is not the case in chroot-script. | ||
if command -v bailout >/dev/null 2>&1; then | ||
bailout 1 | ||
else | ||
|
@@ -289,12 +296,12 @@ | |
fi | ||
done | ||
|
||
[ -x "$MNTPOINT"/bin/umount ] && clean_chroot "$MNTPOINT" umount -a >/dev/null 2>&1 || true | ||
Check warning on line 299 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
|
||
|
||
# ugly, but make sure we really don't leave anything (/proc /proc and | ||
# /dev /dev are intended, trying to work around timing issues, see #657023) | ||
for ARG in /run/udev /sys /proc /proc /dev/pts /dev/pts /dev /dev ; do | ||
[ -x "$MNTPOINT"/bin/umount ] && clean_chroot "$MNTPOINT" umount $ARG >/dev/null 2>&1 || true | ||
Check warning on line 304 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
|
||
umount "$MNTPOINT"/$ARG >/dev/null 2>&1 || true | ||
done | ||
|
||
|
@@ -808,7 +815,7 @@ | |
prompt_for_release() | ||
{ | ||
[ -n "$RELEASE" ] && DEFAULT_RELEASE="$RELEASE" || DEFAULT_RELEASE='bullseye' | ||
RELEASE="$(dialog --stdout --title "${PN}" --default-item $DEFAULT_RELEASE --menu \ | ||
Check warning on line 818 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
Check failure on line 818 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
|
||
"Please enter the Debian release you would like to use for installation:" \ | ||
0 50 8 \ | ||
buster Debian/10 \ | ||
|
@@ -860,7 +867,7 @@ | |
{ | ||
[ -n "$ISO" ] && DEFAULT_MIRROR='local' || DEFAULT_MIRROR='net' | ||
|
||
CHOOSE_MIRROR=$(dialog --stdout --title "$PN" --default-item $DEFAULT_MIRROR \ | ||
Check warning on line 870 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
Check failure on line 870 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
|
||
--menu "Where do you want to install from?" 0 0 0 \ | ||
net "install via network (downloading from mirror)" \ | ||
local "install from local directory/mirror" | ||
|
@@ -870,13 +877,13 @@ | |
[ -n "$MIRROR" ] || MIRROR='http://deb.debian.org/debian' | ||
MIRROR="$(dialog --stdout --title "${PN}" --inputbox \ | ||
"Please enter Debian mirror you would like to use for installing packages." \ | ||
0 0 $MIRROR)" || bailout | ||
Check warning on line 880 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
|
||
|
||
else # CHOOSE_MIRROR == local | ||
[ -n "$ISO" ] || ISO='/mnt/mirror' | ||
ISO="$(dialog --stdout --title "${PN}" --inputbox \ | ||
"Please enter directory name you would like to use for installing packages." \ | ||
0 0 $ISO)" || bailout | ||
Check warning on line 886 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
|
||
fi | ||
} | ||
# }}} | ||
|
@@ -1843,12 +1850,12 @@ | |
[ -n "$TUNE2FS" ] && echo "TUNE2FS='${TUNE2FS//\'/\'\\\'\'}'" >> "$CHROOT_VARIABLES" | ||
[ -n "$VMSIZE" ] && echo "VMSIZE='${VMSIZE//\'/\'\\\'\'}'" >> "$CHROOT_VARIABLES" | ||
|
||
cp $VERBOSE "${CONFFILES}"/chroot-script "${MNTPOINT}"/bin/chroot-script | ||
Check warning on line 1853 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
Check failure on line 1853 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
|
||
chmod 755 "${MNTPOINT}"/bin/chroot-script | ||
[ -d "$MNTPOINT"/etc/debootstrap/ ] || mkdir "$MNTPOINT"/etc/debootstrap/ | ||
|
||
# make sure we have our files for later use via chroot-script | ||
cp $VERBOSE "${CONFFILES}/config" "${MNTPOINT}"/etc/debootstrap/ | ||
Check warning on line 1858 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
Check failure on line 1858 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
|
||
# make sure we adjust the configuration variables accordingly: | ||
sed -i "s#RELEASE=.*#RELEASE=\"$RELEASE\"#" "${MNTPOINT}"/etc/debootstrap/config | ||
sed -i "s#TARGET=.*#TARGET=\"$TARGET\"#" "${MNTPOINT}"/etc/debootstrap/config | ||
|
@@ -1867,20 +1874,20 @@ | |
PACKAGES_FILE="packages-arm64" | ||
fi | ||
|
||
cp $VERBOSE "${_opt_packages:-$CONFFILES/$PACKAGES_FILE}" \ | ||
Check warning on line 1877 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
Check failure on line 1877 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
|
||
"${MNTPOINT}/etc/debootstrap/${PACKAGES_FILE}" | ||
fi | ||
|
||
# debconf preseeding: | ||
_opt_debconf=${_opt_debconf:-$CONFFILES/debconf-selections} | ||
[ -f "${_opt_debconf}" ] && [ "$DEBCONF" = 'yes' ] && \ | ||
cp $VERBOSE "${_opt_debconf}" "${MNTPOINT}"/etc/debootstrap/debconf-selections | ||
Check failure on line 1884 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
|
||
|
||
# copy scripts that should be executed inside the chroot: | ||
_opt_chroot_scripts=${_opt_chroot_scripts:-$CONFFILES/chroot-scripts/} | ||
[ -d "$_opt_chroot_scripts" ] && [ "$CHROOT_SCRIPTS" = 'yes' ] && { | ||
mkdir -p "${MNTPOINT}"/etc/debootstrap/chroot-scripts | ||
cp -a $VERBOSE "${_opt_chroot_scripts}"/* "${MNTPOINT}"/etc/debootstrap/chroot-scripts/ | ||
Check failure on line 1890 in grml-debootstrap GitHub Actions / shellcheck grml-debootstrap
|
||
} | ||
|
||
# notice: do NOT use $CHROOT_VARIABLES inside chroot but statically file instead! | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, I don't understand why this change ends up in this clean_chroot feature/commit, is the github web UI showing something unexpected? o_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure where you saw that. But GitHub says
Outdated
". I cannot see any change related to / near## Check if "bailout" function is available.
in a local git diff.