Disable ext4 feature orphan_file for older releases #285

zeha · 2024-08-17T19:36:21Z

Fixes #278.

zeha · 2024-08-17T19:36:54Z

Should be merged after #284

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1887 in 25c56d2

    
           cp -a $VERBOSE "${_opt_chroot_scripts}"/* "${MNTPOINT}"/etc/debootstrap/chroot-scripts/

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1891 in 25c56d2

cp $VERBOSE "${CHROOT_VARIABLES}" "${MNTPOINT}"/etc/debootstrap/variables

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1893 in 25c56d2

cp $VERBOSE -a -L "${CONFFILES}"/extrapackages/ "${MNTPOINT}"/etc/debootstrap/

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1896 in 25c56d2

    
           [ -f "${MNTPOINT}"/etc/resolv.conf ] || cp $VERBOSE /etc/resolv.conf "${MNTPOINT}"/etc/resolv.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1899 in 25c56d2

    
           [ -n "$LOCALES" ] && cp $VERBOSE "${CONFFILES}"/locale.gen "${MNTPOINT}"/etc/locale.gen

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1902 in 25c56d2

    
           [ -d "${CONFFILES}"/bin   ] && cp $VERBOSE -a -L "${CONFFILES}"/bin/*   "${MNTPOINT}"/bin/

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1903 in 25c56d2

    
           [ -d "${CONFFILES}"/boot  ] && cp $VERBOSE -a -L "${CONFFILES}"/boot/*  "${MNTPOINT}"/boot/

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1904 in 25c56d2

    
           [ -d "${CONFFILES}"/etc   ] && cp $VERBOSE -a -L "${CONFFILES}"/etc/*   "${MNTPOINT}"/etc/

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1905 in 25c56d2

    
           [ -d "${CONFFILES}"/sbin  ] && cp $VERBOSE -a -L "${CONFFILES}"/sbin/*  "${MNTPOINT}"/sbin/

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1906 in 25c56d2

    
           [ -d "${CONFFILES}"/share ] && cp $VERBOSE -a -L "${CONFFILES}"/share/* "${MNTPOINT}"/share/

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1907 in 25c56d2

    
           [ -d "${CONFFILES}"/usr   ] && cp $VERBOSE -a -L "${CONFFILES}"/usr/*   "${MNTPOINT}"/usr/

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1908 in 25c56d2

    
           [ -d "${CONFFILES}"/var   ] && cp $VERBOSE -a -L "${CONFFILES}"/var/*   "${MNTPOINT}"/var/

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1963 in 25c56d2

cp $VERBOSE /etc/network/interfaces "${MNTPOINT}/etc/network/interfaces"

github-actions · 2024-08-17T19:42:38Z

grml-debootstrap

📝 [shellcheck] _{reported by reviewdog 🐶}
Note that A && B || C is not if-then-else. C may run when A is true. SC2015

grml-debootstrap/grml-debootstrap

Line 305 in 25c56d2

[ -x "$MNTPOINT"/bin/umount ] && chroot "$MNTPOINT" umount -a >/dev/null 2>&1 || true

github-actions · 2024-08-17T19:42:39Z

grml-debootstrap

📝 [shellcheck] _{reported by reviewdog 🐶}
Note that A && B || C is not if-then-else. C may run when A is true. SC2015

grml-debootstrap/grml-debootstrap

Line 310 in 25c56d2

[ -x "$MNTPOINT"/bin/umount ] && chroot "$MNTPOINT" umount $ARG >/dev/null 2>&1 || true

github-actions · 2024-08-17T19:42:40Z

grml-debootstrap

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 824 in 25c56d2

RELEASE="$(dialog --stdout --title "${PN}" --default-item $DEFAULT_RELEASE --menu \

github-actions · 2024-08-17T19:42:40Z

grml-debootstrap

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 876 in 25c56d2

CHOOSE_MIRROR=$(dialog --stdout --title "$PN" --default-item $DEFAULT_MIRROR \

github-actions · 2024-08-17T19:42:41Z

grml-debootstrap

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 886 in 25c56d2

0 0 $MIRROR)" || bailout

github-actions · 2024-08-17T19:42:42Z

grml-debootstrap

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 892 in 25c56d2

0 0 $ISO)" || bailout

github-actions · 2024-08-17T19:42:42Z

grml-debootstrap

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1850 in 25c56d2

cp $VERBOSE "${CONFFILES}"/chroot-script "${MNTPOINT}"/bin/chroot-script

github-actions · 2024-08-17T19:42:43Z

grml-debootstrap

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1855 in 25c56d2

cp $VERBOSE "${CONFFILES}/config" "${MNTPOINT}"/etc/debootstrap/

github-actions · 2024-08-17T19:42:44Z

grml-debootstrap

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1874 in 25c56d2

cp $VERBOSE "${_opt_packages:-$CONFFILES/$PACKAGES_FILE}" \

github-actions · 2024-08-17T19:42:44Z

grml-debootstrap

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

grml-debootstrap/grml-debootstrap

Line 1881 in 25c56d2

cp $VERBOSE "${_opt_debconf}" "${MNTPOINT}"/etc/debootstrap/debconf-selections

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck (suggestion)

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 1893 in 25c56d2

cp $VERBOSE -a -L "${CONFFILES}"/extrapackages/ "${MNTPOINT}"/etc/debootstrap/

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 1896 in 25c56d2

    
           [ -f "${MNTPOINT}"/etc/resolv.conf ] || cp $VERBOSE /etc/resolv.conf "${MNTPOINT}"/etc/resolv.conf

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 1899 in 25c56d2

    
           [ -n "$LOCALES" ] && cp $VERBOSE "${CONFFILES}"/locale.gen "${MNTPOINT}"/etc/locale.gen

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Lines 1902 to 1908 in 25c56d2

    
           [ -d "${CONFFILES}"/bin   ] && cp $VERBOSE -a -L "${CONFFILES}"/bin/*   "${MNTPOINT}"/bin/ 
        
           [ -d "${CONFFILES}"/boot  ] && cp $VERBOSE -a -L "${CONFFILES}"/boot/*  "${MNTPOINT}"/boot/ 
        
           [ -d "${CONFFILES}"/etc   ] && cp $VERBOSE -a -L "${CONFFILES}"/etc/*   "${MNTPOINT}"/etc/ 
        
           [ -d "${CONFFILES}"/sbin  ] && cp $VERBOSE -a -L "${CONFFILES}"/sbin/*  "${MNTPOINT}"/sbin/ 
        
           [ -d "${CONFFILES}"/share ] && cp $VERBOSE -a -L "${CONFFILES}"/share/* "${MNTPOINT}"/share/ 
        
           [ -d "${CONFFILES}"/usr   ] && cp $VERBOSE -a -L "${CONFFILES}"/usr/*   "${MNTPOINT}"/usr/ 
        
           [ -d "${CONFFILES}"/var   ] && cp $VERBOSE -a -L "${CONFFILES}"/var/*   "${MNTPOINT}"/var/

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 1963 in 25c56d2

cp $VERBOSE /etc/network/interfaces "${MNTPOINT}/etc/network/interfaces"

github-actions · 2024-08-17T19:42:48Z

grml-debootstrap

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 824 in 25c56d2

RELEASE="$(dialog --stdout --title "${PN}" --default-item $DEFAULT_RELEASE --menu \

github-actions · 2024-08-17T19:42:49Z

grml-debootstrap

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 876 in 25c56d2

CHOOSE_MIRROR=$(dialog --stdout --title "$PN" --default-item $DEFAULT_MIRROR \

github-actions · 2024-08-17T19:42:49Z

grml-debootstrap

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 886 in 25c56d2

0 0 $MIRROR)" || bailout

github-actions · 2024-08-17T19:42:50Z

grml-debootstrap

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 892 in 25c56d2

0 0 $ISO)" || bailout

github-actions · 2024-08-17T19:42:51Z

grml-debootstrap

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 1850 in 25c56d2

cp $VERBOSE "${CONFFILES}"/chroot-script "${MNTPOINT}"/bin/chroot-script

github-actions · 2024-08-17T19:42:52Z

grml-debootstrap

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 1855 in 25c56d2

cp $VERBOSE "${CONFFILES}/config" "${MNTPOINT}"/etc/debootstrap/

github-actions · 2024-08-17T19:42:52Z

grml-debootstrap

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 1874 in 25c56d2

cp $VERBOSE "${_opt_packages:-$CONFFILES/$PACKAGES_FILE}" \

github-actions · 2024-08-17T19:42:53Z

grml-debootstrap

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 1881 in 25c56d2

cp $VERBOSE "${_opt_debconf}" "${MNTPOINT}"/etc/debootstrap/debconf-selections

github-actions · 2024-08-17T19:42:54Z

grml-debootstrap

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 1887 in 25c56d2

cp -a $VERBOSE "${_opt_chroot_scripts}"/* "${MNTPOINT}"/etc/debootstrap/chroot-scripts/

github-actions · 2024-08-17T19:42:54Z

grml-debootstrap

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

grml-debootstrap/grml-debootstrap

Line 1891 in 25c56d2

cp $VERBOSE "${CHROOT_VARIABLES}" "${MNTPOINT}"/etc/debootstrap/variables

grml-debootstrap

mika

Finally we're getting it under control again, thx! \o/

Disable ext4 feature orphan_file for older releases

25c56d2

zeha requested a review from mika August 17, 2024 19:36

zeha self-assigned this Aug 17, 2024

zeha requested a review from jkirk August 17, 2024 19:36

github-actions bot reviewed Aug 17, 2024

View reviewed changes

mika reviewed Aug 19, 2024

View reviewed changes

grml-debootstrap Show resolved Hide resolved

mika approved these changes Aug 19, 2024

View reviewed changes

zeha merged commit 5dd8178 into master Aug 19, 2024
78 checks passed

zeha deleted the zeha/modern-ext4-old-releases branch August 19, 2024 14:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable ext4 feature orphan_file for older releases #285

Disable ext4 feature orphan_file for older releases #285

zeha commented Aug 17, 2024

zeha commented Aug 17, 2024

github-actions bot left a comment

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot left a comment

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

mika left a comment

	[ -d "${CONFFILES}"/bin ] && cp $VERBOSE -a -L "${CONFFILES}"/bin/* "${MNTPOINT}"/bin/
	[ -d "${CONFFILES}"/boot ] && cp $VERBOSE -a -L "${CONFFILES}"/boot/* "${MNTPOINT}"/boot/
	[ -d "${CONFFILES}"/etc ] && cp $VERBOSE -a -L "${CONFFILES}"/etc/* "${MNTPOINT}"/etc/
	[ -d "${CONFFILES}"/sbin ] && cp $VERBOSE -a -L "${CONFFILES}"/sbin/* "${MNTPOINT}"/sbin/
	[ -d "${CONFFILES}"/share ] && cp $VERBOSE -a -L "${CONFFILES}"/share/* "${MNTPOINT}"/share/
	[ -d "${CONFFILES}"/usr ] && cp $VERBOSE -a -L "${CONFFILES}"/usr/* "${MNTPOINT}"/usr/
	[ -d "${CONFFILES}"/var ] && cp $VERBOSE -a -L "${CONFFILES}"/var/* "${MNTPOINT}"/var/

Disable ext4 feature orphan_file for older releases #285

Disable ext4 feature orphan_file for older releases #285

Conversation

zeha commented Aug 17, 2024

zeha commented Aug 17, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

mika left a comment

Choose a reason for hiding this comment