Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shellcheck: restrict shellcheck-tests to tests/*.sh files #288

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

zeha
Copy link
Member

@zeha zeha commented Aug 18, 2024

For unknown reasons the pr-review shellcheck-tests workflow started reporting shellcheck errors in non-shell files in tests/. Supposedly check_all_files_with_shebangs: "false" should prevent this, but alas.

Also fix an actual shellcheck issue.

@zeha zeha requested review from evgeni, mika and jkirk August 18, 2024 13:02
@zeha zeha merged commit cade748 into master Aug 19, 2024
58 of 78 checks passed
@zeha zeha deleted the shellcheck branch August 19, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants