Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netcardconfig: Run ifdown immediately before configuring the network … #10

Closed
wants to merge 1 commit into from
Closed

netcardconfig: Run ifdown immediately before configuring the network … #10

wants to merge 1 commit into from

Conversation

jkirk
Copy link
Contributor

@jkirk jkirk commented Apr 2, 2020

…device

When running netcardconfig the network device is set offline before the
configuration is completed. The network configuration should only be
touched after everything is set.

While at it also removed the sleep phase. The network interface should
be released and down fine after ifdown is completed.

Closes: #8

@jkirk
netcardconfig: Run ifdown immediately before configuring the network …
7f85c93 
…device

When running netcardconfig the network device is set offline before the
configuration is completed. The network configuration should only be
touched after everything is set.

While at it also removed the sleep phase. The network interface should
be released and down fine after ifdown is completed.

Closes: grml#8
@mika
Copy link
Member

mika commented Apr 3, 2020

JFTR, this basically reverts git commit 77958ef, so needs verification if it really does what we want/need (now having the --force option active). Also might be worth mentioning the commit from Chris and explain why we revert this change now.

@jkirk
Copy link
Contributor Author

jkirk commented Apr 9, 2020

I did test the --force option hoping it would bring the interface down no matter how /etc/network/interfaces looks like. Unfortunately it does not work as I have anticipated sigh.

The correct way now (for me) to do it, is to create a /etc/network/interfaces.new with the proposed changes and only after the user approves the changes (or at least after the last setting has been prompted) the interface should be reconfigured (that is ifdown --force, rename interfaces.new -> interfaces, and run ifup). Proxmox seems to do it that way.

Closing this PR therefor.

@jkirk jkirk closed this Apr 9, 2020
@jkirk jkirk mentioned this pull request Apr 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

netcardconfig: configuring interfaces immediately brings them down/offline before configuration finished
2 participants
@jkirk @mika