Try using isoinfo(1) to extract an ISO image identifier #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mika
reviewed
Apr 7, 2023
| { | ||
| local iso=${1} | ||
| local id= | ||
| if isoinfo --version >/dev/null 2>&1 ; then |
There was a problem hiding this comment.
Is there any specific reason why we invoke isoinfo with --version and not check for its availability/executable?
(No big deal though and fine for me, just curious!)
There was a problem hiding this comment.
I figure it's better than test -x (requires hard-coding the binary location) or trying to use which...
|
All right, I've updated the PR. The feedback and guidance are appreciated. Please let me know if anything remains that's not up to snuff. |
|
Thanks also for this, just verified and LGTM, rebased against your PR 15 and just submitted. Thanks again! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first of several PRs stemming from #13. This uses a utility from the
genisoimagepackage, if available, to extract some kind of title string for each ISO image file found.