Use fetch api instead of XHR api#1
Open
nimishsinghal wants to merge 1 commit into
Open
Conversation
nimishsinghal
force-pushed
the
feat-move-XHR-to-fetch
branch
from
c54bf6f to
0c60957
Compare
|
And the browsers that don't support fetch. What about them? |
Author
|
I think the fetch polyfill wil handle that |
anubhav7495
reviewed
Nov 16, 2017
| }, | ||
|
|
||
| _makeRequest: function(opts) { | ||
| var request = _window.XMLHttpRequest && new _window.XMLHttpRequest(); |
anubhav7495
reviewed
Nov 16, 2017
|
|
||
| _makeRequest: function(opts) { | ||
| var request = _window.XMLHttpRequest && new _window.XMLHttpRequest(); | ||
| if (!request) return; |
There was a problem hiding this comment.
if not, either return or request a polyfill
anubhav7495
reviewed
Nov 16, 2017
| if (!request) return; | ||
|
|
||
| // if browser doesn't support CORS (e.g. IE7), we are out of luck | ||
| var hasCORS = 'withCredentials' in request || typeof XDomainRequest !== 'undefined'; |
There was a problem hiding this comment.
You also need to handle CORS issue
anubhav7495
reviewed
Nov 16, 2017
| .then(function(response) { | ||
| opts.onSuccess && opts.onSuccess(); | ||
| }) | ||
| .catch(function(response) { |
There was a problem hiding this comment.
Fetch only rejects in case of network error, scenarios like 404 or else would not trigger this
|
Please require the polyfill. I don't see it in the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please verify the following: