Make dryrun more useful for debugging #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the `--dryrun` flag so that it runs all code, but doesn't update anything in jamf or snipeit. It also introduces a `--connection_test` flag, which takes over the functionality of the old dryrun flag. The main idea behind this is, that for debugging and development purposes it might be useful to run almost all code, but stop short of updating the environment.
jerm
reviewed
Jun 14, 2024
| @@ -60,7 +60,8 @@ import datetime | |||
| runtimeargs = argparse.ArgumentParser() | |||
| runtimeargs.add_argument("-v", "--verbose", help="Sets the logging level to INFO and gives you a better idea of what the script is doing.", action="store_true") | |||
| runtimeargs.add_argument("--auto_incrementing", help="You can use this if you have auto-incrementing enabled in your snipe instance to utilize that instead of adding the Jamf ID for the asset tag.", action="store_true") | |||
| runtimeargs.add_argument("--dryrun", help="This checks your config and tries to contact both the JAMFPro and Snipe-it instances, but exits before updating or syncing any assets.", action="store_true") | |||
| runtimeargs.add_argument("--dryrun", help="This checks your config and tries to contact both the JAMFPro and Snipe-it instances, and will generate the assets for debugging, but not update or sync anything but exits before updating or syncing any assets.", action="store_true") | |||
There was a problem hiding this comment.
but not update or sync anything but exits before updating or syncing any assets.
sound repetitive. maybe end before the second "but"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
--dryrunflag so that it runs all code, but doesn't update anything in jamf or snipeit. It also introduces a--connection_testflag, which takes over the functionality of the old dryrun flag.The main idea behind this is, that for debugging and development purposes it might be useful to run almost all code, but stop short of updating the environment.