Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pagination Support #13

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add Pagination Support #13

wants to merge 2 commits into from

Conversation

m4us1ne
Copy link

@m4us1ne m4us1ne commented May 11, 2023

I failed a bit with cherrypicking in MR #12
This MR only contains the pagination support. i will open another one for the formatting and fstrings.

jerm
jerm reviewed May 16, 2023
View reviewed changes
Copy link
Member

@jerm jerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for submitting this!

Overall this looks great, though i have a few small things I'd like you to have a look at.

thanks again!

kandji2snipe Outdated Show resolved Hide resolved
kandji2snipe Outdated Show resolved Hide resolved
kandji2snipe Outdated Show resolved Hide resolved
@jerm jerm mentioned this pull request May 23, 2023
Open
@uberbrady uberbrady mentioned this pull request Aug 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerm jerm jerm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m4us1ne @jerm @briangoldstein