Skip to content

Conversation

@cz-lucas
Copy link

Added #17494: Advanced-search and predefined filters

New functionality

Advanced search:

  • Added new advanced-search which allows filtering on backend
  • Added functionality to manage private and public filters. The provided new permissions for new functionality
  • Create new settings-page to manage filters

API:

  • Added API to manage the predefined filters

Database:

  • Added tables for predefined filters and predefined filter permissions

Testing:

  • Added plenty of unit- and feature tests for the advanced search and predefined filters
  • Added tests for the "old" advanced search

Screenshots

Advanced search:
image
Predefined filter create modal:
image
Predefined filter settings page
image

cz-lucas and others added 30 commits October 28, 2025 14:59
…plied

Fixed that filter operators wont be applied on textfields
@cz-lucas cz-lucas marked this pull request as ready for review December 3, 2025 09:41
@cz-lucas cz-lucas requested a review from snipe as a code owner December 3, 2025 09:41
@marcusmoore
Copy link
Collaborator

Hi there and thank you for you PR.

It looks like a lot of work went into this but that also means there are a lot of changed files which makes reviewing this difficult 😅.

In order for the team to start reviewing this can you please make the following changes:

  • It looks like a formatter was run for a lot of lines that aren't relevant to the feature. Please remove the formatting changes that are not on lines added or changed while building the feature this PR focuses on.
    • This is helpful for the reviewers before the code is merged and also in the future when we want to track the changes to a file. Formatting for the sake of formatting makes tracking down relevant changes to a file more difficult in the future.
  • Please remove files/changes that seem to be relevant to your local dev environment like the references to Codacy.
  • Please remove the build assets.
    • Those changes should not be included in PRs since they make reviewing a lot more difficult. If needed we build them locally when testing.
  • Please remove the translations except for our source of truth, en-US.
  • Please remove the .gitignore files in the storage directories.
    • I don't think they are necessary?
  • It looks like this PR includes changes that aren't relevant to advanced search and pre-defined filters (like changes to alerts/notifications). Please move those changes to another PR so both features/changes can be reviewed individually.
  • Please provide details about the technical implementation in the PR description.
    • The screenshots are really appreciated so we can get an overview of the new functionality but a walkthrough of the actual code added and changed will go a long way in making the PR review more manageable.

It may seem like a lot but these changes are needed before the team can dive in and start reviewing. We need to get the 21k changed lines down to something manageable for our devs.

Again, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants