Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer props or theme over inline styles #35

Open
halocline opened this issue Sep 9, 2022 · 0 comments
Open

Prefer props or theme over inline styles #35

halocline opened this issue Sep 9, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@halocline
Copy link
Collaborator

Please describe what the rule should do:

What category of rule is this? (place an "X" next to just one item)

[ ] Warns about a potential error (problem)
[x] Suggests an alternate way of doing something (suggestion)
[ ] Other (please specify:)

Provide 2-3 code examples that this rule will warn about:

<Box style={{background: '#345ABC'}} />

Why should this rule be included in eslint-plugin-grommet?

Promotes consistency in implementations across projects. Aims to minimize drift across component instances.

Maybe a better candidate for HPE Design System eslint?
@halocline halocline added the enhancement New feature or request label Sep 9, 2022
@halocline halocline added the help wanted Extra attention is needed label May 23, 2023
@taysea taysea mentioned this issue Jul 24, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@halocline