Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint-plugin-grommet and address issues #3464

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Jul 5, 2023

Deploy Preview

What does this PR do?

Adds eslint-plugin-grommet back to eslint config. Addressed the issues being flagged by the rules.

For some areas where the rules felt inaccurate or overly strict, I filed issues to the eslint-plugin-grommet repo:

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Closes #3403

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@taysea taysea requested review from jcfilben and halocline July 5, 2023 23:31
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@halocline halocline merged commit 4fc15af into master Jul 18, 2023
@halocline halocline deleted the 3404-eslint-plugin-grommet branch July 18, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NextJS 13 + eslint-plugin-grommet compatibility
3 participants