Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Concurrency issues originating in Swift6 #99

Merged
merged 8 commits into from
Aug 19, 2024
Merged

Conversation

fumito-ito
Copy link
Collaborator

@fumito-ito fumito-ito commented Aug 17, 2024

fix #98

Addresses Concurrency warnings caused by Swift 6. This PR contains a breaking change.

The DefaultConfiguration has been deprecated as a breaking change. The following functions, whose behavior could be changed by changing the DefaultConfiguration, can now pass Configuration as an argument. The following modules are affected.

  • TemplateRepository
  • Template
  • Lambda

Rewrote globally declared non-Sendable variables to static computed properties and global function declarations. The following modules are affected.

  • EmptyBox
  • EachFilter
  • ZipFilter
  • DefaultConfiguration

Immutable and static properties that are not Sendable have been rewritten as computed properties. The following modules are affected.

  • StandardLibrary

MustacheError.Kind is now Sendable compatible.

fumito-ito and others added 8 commits August 16, 2024 14:12
…non-thread safe objects.

This change prevents configuration from being shared globally. Therefore, an interface has been added to each function that can receive the configuration.

If no configuration is added, `Configuration.default` is used.
@fumito-ito fumito-ito merged commit 416a6e4 into master Aug 19, 2024
1 check passed
@fumito-ito fumito-ito deleted the fix/concurrency branch August 19, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRMustache not compatible with Swift 6 concurrency checking
1 participant