Add factory based zap payload logging interceptor #469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Request:
We have a use case to extract key-value pairs from the context for the payload logging.
Current state:
The context sent by the grpc framework to the interceptor but there is no hook for payload interceptor user to plug into and be able to decorate the logger with the information in the context object. There are other interceptors which populate the context object.
Solution:
Instead of directly passing on the logger, we create another method that accepts a logger factory. The logger is created only after the context is received with the context object.