Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status code label to server latency histogram #51

Merged
merged 5 commits into from
Nov 22, 2021

Conversation

ashamukov
Copy link
Contributor

@ashamukov ashamukov commented Nov 15, 2021

Hi Dino! Eventually made a PR for #50 :)
@dinowernli

@google-cla
Copy link

google-cla bot commented Nov 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ashamukov
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Member

@dinowernli dinowernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This is generally looking nice, just a few small suggestions here and there.

Copy link
Member

@dinowernli dinowernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, almost there.

@dinowernli dinowernli merged commit 8b4d92e into grpc-ecosystem:master Nov 22, 2021
@dinowernli
Copy link
Member

LGTM, thanks for the contribution.

@ashamukov ashamukov deleted the status-code-label branch November 23, 2021 08:34
@ashamukov
Copy link
Contributor Author

Thanks a lot for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants