-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status code label to server latency histogram #51
Add status code label to server latency histogram #51
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! This is generally looking nice, just a few small suggestions here and there.
src/main/java/me/dinowernli/grpc/prometheus/MonitoringServerCall.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, almost there.
...va/me/dinowernli/grpc/prometheus/integration/MonitoringServerInterceptorIntegrationTest.java
Show resolved
Hide resolved
LGTM, thanks for the contribution. |
Thanks a lot for your help! |
Hi Dino! Eventually made a PR for #50 :)
@dinowernli