Add support for environment variables in config.pb.json strings #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,13 +58,58 @@ public static ConfigurationLoader forFile(Path configFile) { | |||
| ConfigurationSet.Builder configSetBuilder = ConfigurationSet.newBuilder(); | |||
| String fileContent = Joiner.on('\n').join(Files.readAllLines(configFile)); | |||
| JsonFormat.parser().merge(fileContent, configSetBuilder); | |||
| expandEnvironmentVariables(configSetBuilder); | |||
There was a problem hiding this comment.
I am a bit worried that this replacing might be... overly thorough. Is there a chance we could just do the replacement on a whitelisted set of fields?
Then, a small indicator in the proto file that this happens would be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit YOLO; it works for me, but happy to hear suggestions for improvements.