[Chores] Format code #1886
[Chores] Format code #1886
CodeScene PR Check
Quality Gate Failed
(2 files improve in Code Health)
Gates Failed
(2 files with Complex Method, Code Duplication)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| test-soft-math.cpp | 1 advisory rule | 10.00 → 9.39 | Suppress |
| heap_viewer.cc | 1 advisory rule | 6.54 → 6.53 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| assembly.cc | 3.47 → 3.48 | Lines of Code in a Single File |
| ram-viewer.cc | 5.90 → 5.91 | Large Method |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method heap_viewer.cc: PCSX::Widgets::HeapViewer::draw
- Complex Method heap_viewer.cc: PCSX::Widgets::HeapViewer::walkHeap
- Code Duplication test-soft-math.cpp
✅ Improving Code Health:
- Lines of Code in a Single File assembly.cc
- Large Method ram-viewer.cc: PCSX::Widgets::RAMViewer::imguiCB
- Lines of Declarations in a Single File splash.cc
Annotations
Check notice on line 1 in src/gui/splash.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ Getting better: Lines of Declarations in a Single File
The lines of data declarations decreases from 38406 to 34138, threshold = 1500. This file contains many data declarations, leading to a long file.
Check notice on line 1 in src/gui/widgets/assembly.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1057 to 1056, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 320 in src/gui/widgets/heap_viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Complex Method
PCSX::Widgets::HeapViewer::draw already has high cyclomatic complexity, and now it increases in Lines of Code from 160 to 161. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 164 in src/gui/widgets/heap_viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Complex Method
PCSX::Widgets::HeapViewer::walkHeap already has high cyclomatic complexity, and now it increases in Lines of Code from 104 to 105. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 400 in src/gui/widgets/ram-viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ Getting better: Large Method
PCSX::Widgets::RAMViewer::imguiCB decreases from 87 to 86 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 87 in src/mips/tests/psyqo/test-soft-math.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Code Duplication
The module contains 3 functions with similar structure: TEST_CASE,TEST_CASE,TEST_CASE. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.